Skip to content

[Watch App] Introduce Order Details UI #11505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
May 16, 2024
Merged

[Watch App] Introduce Order Details UI #11505

merged 45 commits into from
May 16, 2024

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented May 13, 2024 •
edited
Loading

Summary

Fix issue #11343 and partially fix #11342 by doing the following changes:

  • Introduces the UI transition between the Order List and Order Details
  • Fetch the Order details data from the Database
  • Introduce the OrderDetailsViewModel to handle the Order data
  • Introduce the data exchange between Phone and Watch for the Orders Product data
  • Define the Order Details screen with basic data

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented May 13, 2024 •
edited
Loading

9 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class NavArgs is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class FormatOrderData is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class FetchOrderProducts is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class OrderProductsRequest is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class OrderDetailsViewModel is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class OrdersRequest is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class StoreStatsData is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class GetWearableOrderProducts is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

This was linked to issues May 13, 2024
Introduce Order details screen #11342
Closed
Introduce Order details fetching logic #11343
Closed
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 13, 2024 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit1345b1a
Direct Downloadwoocommerce-prototype-build-pr11505-1345b1a.apk

ThomazFB added 21 commits May 14, 2024 17:29
@ThomazFB
Add Order Details string resources
f37f78f
@ThomazFB
Fix lint issues
0499d55
@ThomazFB
Add Order Refunds fetching support
0bb1f30
@ThomazFB
Fix lint issues
ae7834d
@ThomazFB
Define WearOrderProduct type
fe280df
@ThomazFB
Introduce GetWearableOrderProducts operation
42a9989
@ThomazFB
Add Order Products support to Wearable Paths
5881da0
@ThomazFB
Handle Order products request from WearOS
b1bd678
@ThomazFB
Add the Order ID looping back to the OrderProducts request
b281970
@ThomazFB
Receive and store Order Products data from phone
732f614
@ThomazFB
Refactor Order Products requests from WearableConnectionRepository
bf30bf8
@ThomazFB
Introduce FlowUtils.kt
86b3730
@ThomazFB
Refactor flow with timeout operations
58e4a5b
@ThomazFB
Rename FlowUtils to FlowExt.kt
5fd1247
@ThomazFB
Fix lint issues
cee2912
@ThomazFB
Introduce FetchOrderProducts with data store observation from OrdersR…
30e39f8 
…epository
@ThomazFB
Improve FetchOrderProducts with dedicated Request class
f66a3e6
@ThomazFB
Refactor FetchOrders to follow FetchOrderProducts strategy
98fff08
@ThomazFB
Overhaul Store stats request structure
cb07d29
@ThomazFB
Improve Stats fetching even further
8b4414c
@ThomazFB
Enforce site cohesion inside StatsRepository
d80c0c5
@ThomazFB ThomazFB marked this pull request as ready for review May 16, 2024 04:05
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 40.64%. Comparing base (8651d4f) to head (1345b1a).

Files Patch % Lines
...merce/android/wear/WearableConnectionRepository.kt 0.00% 17 Missing ⚠️
...ocommerce/android/wear/GetWearableOrderProducts.kt 0.00% 13 Missing ⚠️
...rc/main/java/com/woocommerce/commons/wear/Paths.kt 0.00% 7 Missing ⚠️
...oocommerce/commons/wear/orders/WearOrderProduct.kt 0.00% 4 Missing ⚠️
...commerce/android/wear/WearableConnectionService.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                       Coverage Diff                        @@
##             feature/introduce-wear-app   #11505      +/-   ##
================================================================
- Coverage                         40.66%   40.64%   -0.03%     
  Complexity                         5180     5180              
================================================================
  Files                              1081     1083       +2     
  Lines                             62567    62605      +38     
  Branches                           8536     8544       +8     
================================================================
  Hits                              25444    25444              
- Misses                            34835    34873      +38     
  Partials                           2288     2288

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomazFB ThomazFB merged commit 80bdd75 into feature/introduce-wear-app May 16, 2024
14 checks passed
@ThomazFB ThomazFB deleted the issue/android-wear-order-details-ui branch May 16, 2024 05:48
@ThomazFB ThomazFB mentioned this pull request May 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature: android wear type: task An internally driven task. unit-tests-exemption
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Order details fetching logic Introduce Order details screen
4 participants
@ThomazFB @dangermattic @wpmobilebot @codecov-commenter